Fixes #145 Optimize first call to Backtrace::capture with about 40% - 50%#175
Merged
TethysSvensson merged 4 commits intoMay 21, 2026
Merged
Conversation
TethysSvensson
approved these changes
May 21, 2026
Kile-Asmussen
pushed a commit
to Kile-Asmussen/rootcause-work-fork
that referenced
this pull request
May 21, 2026
…th about 40% - 50% (rootcause-rs#175) * Replace regexs with handrolled parser functions * Add tests for match_cargo_registry_path and match_std_library_path * Run cargo clippy * run cargo fmt
Kile-Asmussen
pushed a commit
to Kile-Asmussen/rootcause-work-fork
that referenced
this pull request
May 21, 2026
…th about 40% - 50% (rootcause-rs#175) * Replace regexs with handrolled parser functions * Add tests for match_cargo_registry_path and match_std_library_path * Run cargo clippy * run cargo fmt
Kile-Asmussen
pushed a commit
to Kile-Asmussen/rootcause-work-fork
that referenced
this pull request
May 21, 2026
…th about 40% - 50% (rootcause-rs#175) * Replace regexs with handrolled parser functions * Add tests for match_cargo_registry_path and match_std_library_path * Run cargo clippy * run cargo fmt
Kile-Asmussen
pushed a commit
to Kile-Asmussen/rootcause-work-fork
that referenced
this pull request
May 21, 2026
…th about 40% - 50% (rootcause-rs#175) * Replace regexs with handrolled parser functions * Add tests for match_cargo_registry_path and match_std_library_path * Run cargo clippy * run cargo fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first call to
Backtrace::capturespent about 40% - 50% percent of the time with initializing two regular expression to match library paths.This PR replaces the use of regex with hand rolled parses instead.
Most of the remaining time in the call is spent in
gimliandadd2line.